fix: CodeGen for omit_slice_element_pointers and GetMany Entity Resolvers

plugin/federation/federation.go

@@ -173,7 +173,7 @@ func (f *federation) InjectSourceLate(schema *ast.Schema) *ast.Source {
 					entityResolverInputDefinitions += fmt.Sprintf("\t%s: %s\n", keyField.Field.ToGo(), keyField.Definition.Type.String())
 				}
 				entityResolverInputDefinitions += "}"
-				resolvers += fmt.Sprintf("\t%s(reps: [%s!]!): [%s]\n", r.ResolverName, r.InputTypeName, e.Name)
+				resolvers += fmt.Sprintf("\t%s(reps: [%s]!): [%s]\n", r.ResolverName, r.InputTypeName, e.Name)
 			} else {
 				resolverArgs := ""
 				for _, keyField := range r.KeyFields {

plugin/federation/federation_test.go

@@ -144,6 +144,50 @@ func TestCodeGenerationFederation2(t *testing.T) {
 	require.NoError(t, f.GenerateCode(data))
 }
 
+// This test is to ensure that the input arguments are not
+// changed when cfg.OmitSliceElementPointers is false OR true
+func TestMultiWithOmitSliceElemPointersCfg(t *testing.T) {
+
+	staticRepsString := "reps: [HelloByNamesInput]!"
+	t.Run("OmitSliceElementPointers true", func(t *testing.T) {
+		f, cfg := load(t, "testdata/multi/multi.yml")
+		cfg.OmitSliceElementPointers = true
+		err := f.MutateConfig(cfg)
+		require.NoError(t, err)
+		require.Len(t, cfg.Schema.Types["_Entity"].Types, 1)
+		require.Len(t, f.Entities, 1)
+
+		entityGraphqlGenerated := false
+		for _, source := range cfg.Sources {
+			if source.Name != "federation/entity.graphql" {
+				continue
+			}
+			entityGraphqlGenerated = true
+			require.Contains(t, source.Input, staticRepsString)
+		}
+		require.True(t, entityGraphqlGenerated)
+	})
+
+	t.Run("OmitSliceElementPointers false", func(t *testing.T) {
+		f, cfg := load(t, "testdata/multi/multi.yml")
+		cfg.OmitSliceElementPointers = false
+		err := f.MutateConfig(cfg)
+		require.NoError(t, err)
+		require.Len(t, cfg.Schema.Types["_Entity"].Types, 1)
+		require.Len(t, f.Entities, 1)
+
+		entityGraphqlGenerated := false
+		for _, source := range cfg.Sources {
+			if source.Name != "federation/entity.graphql" {
+				continue
+			}
+			entityGraphqlGenerated = true
+			require.Contains(t, source.Input, staticRepsString)
+		}
+		require.True(t, entityGraphqlGenerated)
+	})
+}
+
 func TestInjectSourceLate(t *testing.T) {
 	_, cfg := load(t, "testdata/allthethings/gqlgen.yml")
 	entityGraphqlGenerated := false

plugin/federation/readme.md

@@ -37,3 +37,6 @@ func (r *entityResolver) FindManyMultiHellosByName(ctx context.Context, reps []*
   /// <Your code to resolve the list of items>
 }
 ```
+
+**Note:**
+If you are using `omit_slice_element_pointers: true` option in your config yaml, your `GetMany` resolver will still generate in the example above the same signature `FindManyMultiHellosByName(ctx context.Context, reps []*generated.ManyMultiHellosByNameInput) ([]*generated.MultiHello, error)`. But all other instances will continue to honor `omit_slice_element_pointers: true`