Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dedupExchange #2998

Conversation

erka
Copy link
Contributor

@erka erka commented Apr 8, 2024

dedupExchange was deprecated in v4.0.0 and is removed now. That release note says

  • Deprecate the dedupExchange. The functionality of deduplicating queries and subscriptions has now been moved into and absorbed by the Client.
    Previously, the Client already started doing some work to share results between
    queries, and to avoid dispatching operations as needed. It now only dispatches operations
    strictly when the dedupExchange would allow so as well, moving its logic into the
    Client

In this release they just

Remove deprecated dedupExchange

@coveralls
Copy link

Coverage Status

coverage: 75.124% (-0.04%) from 75.167%
when pulling e3a1d28 on erka:remove-depc-dedupExchange
into 8780544 on 99designs:dependabot/npm_and_yarn/integration/urql-4.0.7.

@StevenACoffman StevenACoffman merged commit 284ea3e into 99designs:dependabot/npm_and_yarn/integration/urql-4.0.7 Apr 9, 2024
17 checks passed
StevenACoffman pushed a commit that referenced this pull request Apr 9, 2024
* Bump urql from 4.0.6 to 4.0.7 in /integration

Bumps [urql](https://github.com/urql-graphql/urql/tree/HEAD/packages/react-urql) from 4.0.6 to 4.0.7.
- [Release notes](https://github.com/urql-graphql/urql/releases)
- [Changelog](https://github.com/urql-graphql/urql/blob/main/packages/react-urql/CHANGELOG.md)
- [Commits](https://github.com/urql-graphql/urql/commits/urql@4.0.7/packages/react-urql)

---
updated-dependencies:
- dependency-name: urql
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: remove dedupExchange as it was removed and logic moved into a (#2998)

client.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@StevenACoffman
Copy link
Collaborator

@erka (and @UnAfraid too!) Thanks so much for looking at this while I was on my road trip!

@erka erka deleted the remove-depc-dedupExchange branch April 9, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants