fix unexpected ctx variable capture on Tracing #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2018
|
Looks good, but this could use a test. |
vvakame
force-pushed
the
fix-capture-ctx
branch
from
247e4ba
to
a2c33f1
Compare
|
did it! |
vektah
reviewed
Nov 12, 2018
vektah
reviewed
Nov 12, 2018
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
fix unexpected ctx variable capture on Tracing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried Tracing with reqCtx.GetErrors, but I can't get errors expectedly.
BAD: https://play.golang.org/p/AswrHXxcgT7
GOOD: https://play.golang.org/p/Ftk_SLFVVgw
https://golang.org/ref/spec#Defer_statements
I have: