Fix Todo Example Directive #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should always be true, and currently has a bug when comparing pointers to structs. Can just be removed.
mathewbyrne
force-pushed
the
fix-todo-directive
branch
from
fcf54d5
to
5e1bcfa
Compare
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Fix Todo Example Directive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #483 — a minor issue in the Todo example where the directive is checking for a pointer type, but breaks when the return type is a struct.
This will change anyway when is implemented #375, but this fixes the issue for now.