Move ambient imports into cmd package #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getting started docs for dep suggest creating a local gqlgen script, however these ambient import are in the root, so dep misses them. This was changed in 0.8 but the ambient imports weren't moved.
vektah
approved these changes
Mar 16, 2019
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Move ambient imports into cmd package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getting started docs for
depsuggest creating a local gqlgen script, however these ambient import are in the root package, sodepmisses them and introspection (and probably other required packages) are missed and fail during codegen.This was due to changes between 0.7 and 0.8 where the binary was re-added, but the ambient imports weren't moved.