Fix Having Pointers to Union Types #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewbyrne
commented
Mar 18, 2019
codegen/config/binder.go
Outdated
| } | ||
|
|
||
| if !t.NonNull && usePtr { | ||
| def := b.schema.Types[t.Name()] | ||
| usePtr := def.Kind != ast.Interface && def.Kind != ast.Union |
There was a problem hiding this comment.
@vektah this potentially changes the logic a little bit here, since usePtr is recalculated at each recursion, but I think it's maybe more technically correct? Nothing unexpected seemed to shift after codegen.
There was a problem hiding this comment.
👍 I think its effectively the same thing.
mathewbyrne
force-pushed
the
fix-union-pointers
branch
from
ccc398d
to
ad0c35f
Compare
added 2 commits
March 18, 2019 14:48
This is probably a more correct way to check whether we should wrap the type in a pointer or not, rather than looking at the GrapQL definition. There may be use-cases where a GraphQL interface/union might be mapped to a Go stuct.
mathewbyrne
force-pushed
the
fix-union-pointers
branch
from
ad0c35f
to
f02dabb
Compare
vektah
approved these changes
Mar 18, 2019
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Fix Having Pointers to Union Types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #594
Adds unions to the list of things that aren't turned into pointers based on the schema. I also rewrote
CopyModifiersFromAstto make it a bit simpler to use.