Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending variables resolving capabilities #3

Merged
merged 10 commits into from Oct 18, 2012

Conversation

picpoc
Copy link
Contributor

@picpoc picpoc commented Sep 14, 2012

  • Add support for variables in default value
property=${not.found|${not.found.again|Crap!}}

# property = Crap!

not.found.again=Fallback!

# property = Fallback!
...
  • Add support for dynamic variables
hello.en=Hi!
hello.fr=Salut !
hello.i18n=${hello.${locale|en}}

# hello.i18n = Hi!

locale=fr

# hello.i18n = Salut!
  • Prevent infinite loop for recursive variables
# Will not thow a stack overflow
GNU=${GNU}'s Not UNIX
  • Add support for configuration hell and free headaches
g=2g
gg2=2
h=${${${g}4|${g}2}}
2g=gg
2g2=4
gg=${h}${4|${${2g}2}}


# gg=42
  • Add test cases relative to variables resolving.

May need some refactoring and optimization.

@simonetripodi
Copy link
Contributor

Many apologize to join the discussion so late - github didn't send me the email notification about that pullrequest - anyway, better late than never ;)

Proposals are cool, just give me the time to review them and I will merge them!!!

May I can kindly ask you to add few notes in the documentation as well? It would simplify the release process ;)

Thanks a lot for contributing back!
-Simo

@simonetripodi
Copy link
Contributor

Very well done Picpoc, I am going to merge it, congrats and thanks for the hard work!

Could you please send me in PVT your email contact? I have something to speak with you! TIA!

simonetripodi added a commit that referenced this pull request Oct 18, 2012
Extending variables resolving capabilities
@simonetripodi simonetripodi merged commit d255fcd into 99soft:master Oct 18, 2012
simonetripodi added a commit that referenced this pull request Nov 17, 2012
Missing commits from pull request #3 plus patch for issue #4

I will take care on rearranging internal stuff - next release under the ASF umbrella! :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants