You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The developer implementation doesn't have package.json included. If package.json is move to the project starter template, that means the developer need webpack.config.js included in order to build the project. But this doesn't make sense because these are framework assets general for everyone rather than per implementation. So, webpack.config.js should reside in oils framework, and shouldn't be included in the project starter template.
However this creates another issues in the source code management. We don't want built or dynamically generated file from sources to be committed into the VCS. It is a redundancy and may create confusion and inconsistencies when one injected their logic in the built script instead of the script source.
Thus, a suggestion is still not to commit the built script and keep only the source, but the source is build after installation of the framework.
This can be achieve by modifying the behavior of the setup.py such that after downloading the source, it setup the npm environment, install the package.jsonand lastly runs thewebpack` to build the asset sources. and store the built into the installed framework directory.
The text was updated successfully, but these errors were encountered:
The developer implementation doesn't have
package.json
included. Ifpackage.json
is move to the project starter template, that means the developer needwebpack.config.js
included in order to build the project. But this doesn't make sense because these are framework assets general for everyone rather than per implementation. So,webpack.config.js
should reside in oils framework, and shouldn't be included in the project starter template.However this creates another issues in the source code management. We don't want built or dynamically generated file from sources to be committed into the VCS. It is a redundancy and may create confusion and inconsistencies when one injected their logic in the built script instead of the script source.
Thus, a suggestion is still not to commit the built script and keep only the source, but the source is build after installation of the framework.
This can be achieve by modifying the behavior of the
setup.py
such that after downloading the source, it setup the npm environment, install the package.jsonand lastly runs the
webpack` to build the asset sources. and store the built into the installed framework directory.The text was updated successfully, but these errors were encountered: