Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Build System for different setup. #43

Open
9gix opened this issue Feb 28, 2017 · 0 comments
Open

Frontend Build System for different setup. #43

9gix opened this issue Feb 28, 2017 · 0 comments
Assignees
Milestone

Comments

@9gix
Copy link
Owner

9gix commented Feb 28, 2017

The developer implementation doesn't have package.json included. If package.json is move to the project starter template, that means the developer need webpack.config.js included in order to build the project. But this doesn't make sense because these are framework assets general for everyone rather than per implementation. So, webpack.config.js should reside in oils framework, and shouldn't be included in the project starter template.

However this creates another issues in the source code management. We don't want built or dynamically generated file from sources to be committed into the VCS. It is a redundancy and may create confusion and inconsistencies when one injected their logic in the built script instead of the script source.

Thus, a suggestion is still not to commit the built script and keep only the source, but the source is build after installation of the framework.

This can be achieve by modifying the behavior of the setup.py such that after downloading the source, it setup the npm environment, install the package.jsonand lastly runs thewebpack` to build the asset sources. and store the built into the installed framework directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant