Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update authelia example to authelia v4.38 #170

Merged
merged 2 commits into from
Mar 14, 2024
Merged

update authelia example to authelia v4.38 #170

merged 2 commits into from
Mar 14, 2024

Conversation

hendrik1120
Copy link
Contributor

Hello, this small PR will update the authelia example configuration to the latest authelia version.

Authelia v4.38 will default to using the client_secret_basic authentication method, as described in the release post to follow the OIDC specification.

Not setting the token_endpoint_auth_method to client_secret_post will generate the following error:

Access Request failed with error: Client authentication failed (e.g., unknown client, no client authentication included, or unsupported authentication method). 
The request was determined to be using 'token_endpoint_client_auth_method' method 'client_secret_post', however the OAuth 2.0 client does not support this method. 
The registered client with id 'jellyfin' only supports 'token_endpoint_client_auth_method' method 'client_secret_basic'.

Please note that this configuration change is not backwards compatible to any version prior to v4.38.

I am open to any feedback regarding this change. If you don't experience the same issue while using authelia v4.38 please leave a comment down below.

fix warnings in authelia
fix authelia using client_secret_basic instead of client_secret_post
@9p4
Copy link
Owner

9p4 commented Mar 14, 2024

Perhaps the docs should include a note for both versions instead of replacing it outright? ie: "for Authelia < 4.38: ..., and for Authelia >= 4.38: ..." or something of the sort.

@hendrik1120
Copy link
Contributor Author

From my point of view, there was no reason to stick to an old minor release without any security updates while OIDC still being in beta, but I added the old config back.

@9p4 9p4 merged commit 2724d64 into 9p4:main Mar 14, 2024
2 checks passed
@james-d-elliott
Copy link

Thanks for this! We're also adding a guide to our site for reference. Would really appreciate a sanity check on it as I don't use Jellyfin (particularly around the steps involved in configuring the plugin/jellyfin itself):

https://deploy-preview-7148--authelia-staging.netlify.app/integration/openid-connect/jellyfin/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants