fix: make user creation more robust #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverse logic of CreateCanonicalLinkAndUserIfNotExist() to first check if the user exists, then create the canonical link. This allows seamless re-creation of users through SSO after they have been deleted from Jellyfin but not properly de-linked.
|
Thanks for the PR! I'll try to check it out later today 🌝 |
|
I didn't mean to merge main in ugh |
strazto
force-pushed
the
make-user-creation-more-robust
branch
from
2a4b95c
to
d06f680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user is created through SSO, then deleted through Jellyfin, but not de-linked, then the same user is prevented from logging in again.
The reason is that the canonical link resolves to a non-existing user and the plugin crashes in Authenticate() when trying to dereference a null object.
The patch reverses the logic of CreateCanonicalLinkAndUserIfNotExist() to first check if the user exists,
then create the canonical link. It also cleans up trailing links when creating the user.
This allows seamless re-creation of users through SSO after they have been deleted from Jellyfin but not properly de-linked.