Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale parameter doesn't work anymore #16

Closed
A---- opened this issue Sep 30, 2015 · 5 comments
Closed

Scale parameter doesn't work anymore #16

A---- opened this issue Sep 30, 2015 · 5 comments

Comments

@A----
Copy link
Owner

A---- commented Sep 30, 2015

@GeoffreyOfficial found out that when you scale attribute doesn't work anymore when used with sourceWidth / sourceHeight. See issue #14 .

A---- added a commit that referenced this issue Sep 30, 2015
@A----
Copy link
Owner Author

A---- commented Sep 30, 2015

OK @GeoffreyOfficial, I pulled a hot-fix out of my hat.
What was happening is that I changed the way canvg drew on the canvas from a shorthand to a longer version. Shorthand sets the option ignoreDimensions to true while the longer one assume false.

I'll do a proper release later. In the meanwhile, you can use the master branch.

JsFiddle: http://jsfiddle.net/b5grLj7j/1/

@A----
Copy link
Owner Author

A---- commented Sep 30, 2015

Also, your example from the 1.0 could work. Raw github files are served as text/plain and those can't be used in a <script /> tag.

More info there: http://geekdave.com/2013/06/19/linking-raw-github-files-from-jsfiddle/

@GeoffreyOfficial
Copy link

Can I call you, master or senpai ?
Anyway, you are a monster, thank you for this very very very v... fast update ! I have no problem, now, this is perfect, I have my image and the scale ! <3

@A----
Copy link
Owner Author

A---- commented Oct 1, 2015

Sure 😉

@A---- A---- closed this as completed Oct 1, 2015
@A----
Copy link
Owner Author

A---- commented Oct 2, 2015

Proper release is 1.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants