Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error parameter returned by mocked superagent to match the docume… #34

Merged
merged 1 commit into from
Sep 21, 2016
Merged

Fix error parameter returned by mocked superagent to match the docume… #34

merged 1 commit into from
Sep 21, 2016

Conversation

kmudrick
Copy link
Collaborator

@kmudrick kmudrick commented Sep 2, 2016

…nted superagent error handling

@coveralls
Copy link

coveralls commented Sep 2, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 19b78b7 on kmudrick:fix-error-param into 72b96a6 on A:master.

@kmudrick
Copy link
Collaborator Author

kmudrick commented Sep 2, 2016

See http://visionmedia.github.io/superagent/#error-handling - superagent itself sends a more robust error than what this mocks out in error scenarios

@kmudrick kmudrick mentioned this pull request Sep 3, 2016
Merged
@tbranyen tbranyen merged commit 244d890 into A:master Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmudrick @coveralls @tbranyen