Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locale dependent plugins should not assume default locale #21

Closed
iamstarkov opened this issue Dec 3, 2015 · 4 comments
Closed

locale dependent plugins should not assume default locale #21

iamstarkov opened this issue Dec 3, 2015 · 4 comments

Comments

@iamstarkov
Copy link
Collaborator

the case that plugins’ authors cannot imagine all possible usage cases, so its pretty dangerous to make these assumption. So the best trade off, is just to do nothing with input if passed locale is not defined, the same goes with locales not supported by plugin. What do you think?

@A
Copy link
Owner

A commented Dec 3, 2015

I guess it's the responsibility of the plugins developers, but not framework.

@iamstarkov
Copy link
Collaborator Author

yep, it is. but whats about to be careful with undefined locale?

@A
Copy link
Owner

A commented Dec 4, 2015

-1 from me. It will make api harder.

@A
Copy link
Owner

A commented Dec 4, 2015

Plugin developer must take a care about this case.

@A A closed this as completed Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants