forked from python/devguide
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Document using Github issues as the issue tracker (python#814)
- Loading branch information
Showing
17 changed files
with
478 additions
and
471 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
GitHub issues for BPO users | ||
=========================== | ||
|
||
Here are some frequently asked quesions about how to do things in | ||
Github issues that you used to be able to do on `bpo`_. | ||
|
||
Before you ask your own question, make sure you read :doc:`tracker` | ||
and :doc:`triaging` (specifically including :doc:`gh-labels`) as those | ||
pages include a lot of introductory material. | ||
|
||
How to format my comments nicely? | ||
--------------------------------- | ||
|
||
There is a wonderful `beginner guide to writing and formatting on Github | ||
<https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github>`_. | ||
Highly recommended. | ||
|
||
One pro-tip we can sell you right here is that if you want to paste | ||
some longer log as a comment, attach a file instead (see how below). | ||
If you still insist on pasting it in your comment, do it like this:: | ||
|
||
<details> | ||
<summary>This is the summary text, click me to expand</summary> | ||
|
||
Here goes the long, long text. | ||
It will be collapsed by default! | ||
</details> | ||
|
||
How to attach files to an issue? | ||
-------------------------------- | ||
|
||
Drag them into the comment field, wait until the file uploads, and Github | ||
will automatically put a link to your file in your comment text. | ||
|
||
How to link to file paths in the repository when writing comments? | ||
------------------------------------------------------------------ | ||
|
||
Use Markdown links. If you link to the default Github path, the file | ||
will link to the latest current version on the given branch. | ||
|
||
You can get a permanent link to a given revision of a given file by | ||
`pressing "y" <https://docs.github.com/en/repositories/working-with-files/using-files/getting-permanent-links-to-files>`_. | ||
|
||
How to do advanced searches? | ||
---------------------------- | ||
|
||
Use the `Github search syntax`_ or the interactive `advanced search`_ form | ||
that generates search queries for you. | ||
|
||
Where is the "nosy list"? | ||
------------------------- | ||
|
||
Subscribe another person to the issue by tagging them in the comment with | ||
``@username``. | ||
|
||
If you want to subscribe yourself to an issue, click the *🔔 Subscribe* | ||
button in the sidebar. | ||
|
||
Similarly, if you were tagged by somebody else but | ||
decided this issue is not for you, you might click the *🔕 Unsubscribe* | ||
button in the sidebar. | ||
|
||
There is no exact equivalent of the "nosy list" feature, so to preserve | ||
this information during the transfer, we list the previous members of | ||
this list in the first message on the migrated issue. | ||
|
||
How to add issue dependencies? | ||
------------------------------ | ||
|
||
Add a checkbox list like this in the issue description:: | ||
|
||
- [x] #739 | ||
- [ ] https://github.com/octo-org/octo-repo/issues/740 | ||
- [ ] Add delight to the experience when all tasks are complete :tada: | ||
|
||
then those will become sub-tasks on the given issue. Moreover, Github will | ||
automatically mark a task as complete if the other referenced issue is | ||
closed. More details in the `official Github documentation | ||
<https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists>`_. | ||
|
||
What on Earth is a "mannequin"? | ||
------------------------------- | ||
|
||
For issues migrated to Github from `bpo`_ where the authors or commenters | ||
are not core developers, we opted not to link to their Github accounts | ||
directly. Users not in the `python organization on Github | ||
<https://github.com/orgs/python/people>`_ might not like comments to | ||
appear under their name from an automated import. Others never linked Github on | ||
`bpo`_ in the first place so linking their account, if any, would be impossible. | ||
|
||
In those cases a "mannequin" account is present to help follow the conversation | ||
that happened in the issue. In case the user did share their Github account | ||
name in their `bpo_` profile, we use that. Otherwise, their classic `bpo_` | ||
username is used instead. | ||
|
||
Where did the "Resolution" field go? | ||
------------------------------------ | ||
|
||
Based on historical data we found it not being used very often. | ||
|
||
Where did the "Low", "High", and "Critical" priorities go? | ||
---------------------------------------------------------- | ||
|
||
Based on historical data we found those not being used very often. | ||
|
||
How to find a random issue? | ||
--------------------------- | ||
|
||
This is not supported by Github. | ||
|
||
Where are regression labels? | ||
---------------------------- | ||
|
||
We rarely updated this information and it turned out not to be | ||
particularly useful outside of the change log. | ||
|
||
|
||
.. _bpo: https://bugs.python.org/ | ||
.. _Github search syntax: https://docs.github.com/en/search-github/getting-started-with-searching-on-github/understanding-the-search-syntax | ||
.. _advanced search: https://github.com/search/advanced |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,170 @@ | ||
.. _github-labels: | ||
|
||
Github Labels | ||
============= | ||
|
||
We're using labels on Github to categorize issues and pull requests. | ||
Many labels are shared for both use cases, while some are dedicated | ||
only to one. Below is a possibly inexhaustive list, but it should get | ||
you going. For a full list, see `here <https://github.com/python/cpython/issues/labels>`_. | ||
|
||
General purpose labels | ||
---------------------- | ||
|
||
type-behavior | ||
Used for issues/PRs that address unintentional behavior, but do not | ||
pose significant security concerns. Generally, bugfixes will be attached | ||
to a specific issue where the unintended behavior was first reported. | ||
|
||
type-documentation | ||
Used for issues/PRs that exclusively involve changes to | ||
the documentation. Documentation includes `*.rst` files, docstrings, | ||
and code comments. | ||
|
||
type-enhancement | ||
Used for issues/PRs that provide additional functionality | ||
or capabilities beyond the existing specifications. | ||
|
||
type-performance | ||
Used for issues/PRs that provide performance optimizations. | ||
|
||
type-security | ||
Used for issues/PRs that involve critical security issues. Less severe | ||
security concerns can instead use the type-bugfix label. | ||
|
||
type-tests | ||
Used for issues/PRs that exclusively involve changes to the tests. | ||
|
||
OS-Mac / OS-Windows | ||
Used for issues/PRs involving changes which only have an effect upon | ||
a specific operating system. | ||
|
||
spam | ||
Used for issues/PRs that don't include enough eggs or bacon. | ||
|
||
Labels specific to issues | ||
------------------------- | ||
|
||
Priority | ||
^^^^^^^^ | ||
|
||
release-blocker | ||
The highest priority of an issue. If unaddressed, will cause the | ||
release manager to hold releasing a new version of Python. | ||
|
||
deferred-blocker | ||
A release blocker that was pushed one or more releases into the | ||
future. Possibly a temporary workaround was employed, or the version | ||
of Python the issue is affecting is still in alpha or beta stages | ||
of development. | ||
|
||
Component | ||
^^^^^^^^^ | ||
|
||
library | ||
Used for issues involving Python modules in the ``Lib/`` dir. | ||
|
||
documentation | ||
Used for issues involving documentation in the ``Doc/`` dir. | ||
|
||
interpreter-core | ||
Used for issues in interpreter core (``Objects/``, ``Python/``, | ||
``Grammar/``, and ``Parser/`` dirs). | ||
|
||
extension-modules | ||
Used for issues involving C modules in the ``Modules/`` dir. | ||
|
||
tests | ||
Used for issues involving only Python's regression test suite, i.e. | ||
files in the ``Lib/test/`` dir. | ||
|
||
Other | ||
^^^^^ | ||
|
||
new | ||
Denotes that the issue hasn't been looked at by triagers or core | ||
developers yet. | ||
|
||
easy | ||
Denotes that the issue is a good candidate for a newcomer to address. | ||
|
||
|
||
Labels specific to PRs | ||
---------------------- | ||
|
||
DO-NOT-MERGE | ||
Used on PRs to prevent miss-islington from being able | ||
to automatically merge the pull request. This label is appropriate when a PR | ||
has a non-trivial conflict with the branch it is being merged into. | ||
|
||
expert-asyncio | ||
Used for PRs which involve changes to the asyncio module | ||
or other asynchronous frameworks that utilize it. | ||
|
||
invalid | ||
Used manually for PRs that do not meet basic requirements and | ||
automatically added by bedevere when PR authors attempt to merge maintenace | ||
branches into the main branch. During events such as the October | ||
Hacktoberfest, this label will prevent the PR from counting toward the | ||
author's contributions. | ||
|
||
needs backport to X.Y | ||
Used for PRs which are appropriate to backport to | ||
branches prior to main. Generally, backports to the maintenance branches | ||
are primarily bugfixes and documentation clarifications. Backports to the | ||
security branches are strictly reserved for PRs involving security fixes, such as | ||
crashes, privilege escalation, and DoS. The use of this label will cause | ||
miss-islington to attempt to automatically merge the PR into the branches | ||
specified. | ||
|
||
skip issue | ||
Used for PRs which involve trivial changes, such as typo fixes, | ||
comment changes, and section rephrases. The majority of PRs require | ||
an issue to be attached to, but if there are no code changes and the | ||
section being modified retains the same meaning, this label might be | ||
appropriate. | ||
|
||
skip news | ||
Similar to the skip issue label, this label is used for PRs which | ||
involve trivial changes, backports, or already have a relevant news entry | ||
in another PR. Any potentially impactful changes should have a | ||
corresponding news entry, but for trivial changes it's commonly at the | ||
discretion of the PR author if they wish to opt-out of making one. | ||
|
||
sprint | ||
Used for PRs authored during an in-person sprint, such as | ||
at PyCon, EuroPython, or other official Python events. The label is | ||
used to prioritize the review of those PRs during the sprint. | ||
|
||
stale | ||
Used for PRs that include changes which are no longer relevant, or when the | ||
author hasn't responded to feedback in a long period of time, or when the | ||
reviewer is unresponsive. This label helps core developers quickly identify | ||
PRs that are candidates for closure or require a ping to the author or | ||
reviewer. | ||
|
||
awaiting review | ||
Used for PRs that haven't been reviewed by anyone yet. | ||
|
||
awaiting core review | ||
Used when the PR is authored by a core developer or when a non-core | ||
developer has reviewed the PR, even if they requested changes. | ||
Note that reviewers could have been added manually by a triager or core | ||
developer, or included automatically through use of the `CODEOWNERS | ||
<https://github.com/python/cpython/blob/main/.github/CODEOWNERS>`_ | ||
file. | ||
|
||
awaiting changes | ||
A reviewer required changes to proceed with the PR. | ||
|
||
awaiting change review | ||
The PR author made requested changes, and they are waiting for review. | ||
|
||
awaiting merge | ||
The PR has been approved by a core developer and is ready to merge. | ||
|
||
test-with-buildbots | ||
Used on PRs to test the latest commit with the buildbot fleet. Generally for | ||
PRs with large code changes requiring more testing before merging. This | ||
may take multiple hours to complete. Triagers can also stop a stuck build | ||
using the web interface. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.