Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Adding testing #5

Merged
merged 7 commits into from
Oct 28, 2018
Merged

WIP: Adding testing #5

merged 7 commits into from
Oct 28, 2018

Conversation

bertilhatt
Copy link
Contributor

Why

This is part of my Hacktoberfest effort
Response to issue #4

How

Adding trivial tests for now.

Comments

Still need to find a good test expectation for test_search_jobs

# Why # 

_This is part of my Hacktoberfest effort_
Response to issue AAYBS#4

# How # 

Adding trivial tests for now.

# Comments # 

Still need to find a good test expectation for `test_search_jobs`
@ZoranPandovski
Copy link
Member

Thanks, @bertilhatt . Following upwork documentations, unfortunately, they don't currently provide a test environment for Upwork API. For testing API calls, they suggest using mocking technology

@bertilhatt
Copy link
Contributor Author

Yeah, that’s 100% the right approach. Sorry — I haven’t had time to look at this, and I need to switch gear, but I should be able to do it later this week. Let me know if I’m blocking something.

@ZoranPandovski
Copy link
Member

Sure, no problem @bertilhatt

@bertilhatt
Copy link
Contributor Author

bertilhatt commented Oct 28, 2018

Hello again,
Been trying to get the test to work locally.
I’ve been able to get the overall structure to work, but I’ve hit a snag: I keep seeing an error that upwork.Client doesn’t exist. I can see that this is the pattern described in UpWork documentation so I’m not sure what’s wrong there.
Let me know if those tests run and pass locally for you.

@ZoranPandovski
Copy link
Member

@bertilhatt Code looks good, I will merge your PR and I will fix tests.

@ZoranPandovski ZoranPandovski merged commit d8c5561 into AAYBS:master Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants