Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greater DataContractSerializer compatibility #22

Closed
AArnott opened this issue Dec 16, 2018 · 4 comments
Closed

Greater DataContractSerializer compatibility #22

AArnott opened this issue Dec 16, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@AArnott
Copy link
Owner

AArnott commented Dec 16, 2018

no existing resolver can simulate DataContractSerializer.
ex:

[DataContract]
public class Master {
    [DataMember]
    public string A { get; set; }
    [DataMember]
    internal Detail B { get; set; }
}
public class Detail {
    public string B1 { get; set; }
    internal string B2 { get; set; }
}

The original DataContractSerializer, includes A, B and B1.
The ContractlessStandardResolver only includes A.
The ContractlessStandardResolverAllowPrivate, include A, B and B1 and B2.

Originally posted by @fredliex in #18 (comment)

@AArnott AArnott self-assigned this Dec 16, 2018
@AArnott AArnott added the enhancement New feature or request label Dec 16, 2018
@AArnott
Copy link
Owner Author

AArnott commented Dec 16, 2018

I'm working on a test to repro this.

@peterwald
Copy link

It would be very helpful if we can also handle internal [DataContract] classes with internal [DataMember] properties as well.

[DataContract]
internal class Master {
    [DataMember]
    internal string A { get; set; }
    [IgnoreDataMember]
    internal string B { get; set; }
}

@AArnott
Copy link
Owner Author

AArnott commented Apr 3, 2019

Internal classes might work, depending on the real outcome of MessagePack-CSharp#88

@AArnott
Copy link
Owner Author

AArnott commented Dec 6, 2019

If this isn't already working in 2.0, please open a new issue on the root project (not my fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants