Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework version 2.0 #88

Closed
oghenez opened this issue Sep 30, 2021 · 3 comments · Fixed by #89
Closed

Framework version 2.0 #88

oghenez opened this issue Sep 30, 2021 · 3 comments · Fixed by #89

Comments

@oghenez
Copy link

oghenez commented Sep 30, 2021

Hi,

Because of the massiveness of my project, upgrading outright to .NET 4.5 isn't feasible right now
Any compatible version for .net 2.0 or 3.5

Thanks
@AArnott
Copy link
Owner

AArnott commented Oct 1, 2021

There is not. But I just gave it a few minutes of effort and I can add such support.

AArnott added a commit that referenced this issue Oct 1, 2021
@AArnott
Add net35 support
b304365 
It's still supported by Windows, after all.

Closes #88
@AArnott AArnott mentioned this issue Oct 1, 2021
Merged
AArnott added a commit that referenced this issue Oct 1, 2021
@AArnott
Add net35 support
d6e4d97 
It's still supported by Windows, after all.

Closes #88
@AArnott
Copy link
Owner

AArnott commented Oct 1, 2021

It turned out to take a little more than a few minutes. It turns out that dotnet build on linux doesn't support building libraries that include .resx files that target net35. But I switched to a Windows agent and made a few other changes to make it work and enhance tests a bit too.

@AArnott
Copy link
Owner

AArnott commented Oct 1, 2021 •
edited
Loading

This will go out to nuget.org shortly as a 2.6-beta.

AArnott pushed a commit that referenced this issue May 2, 2023
@dependabot
Bump coverlet.msbuild from 2.9.0 to 3.0.2 (#88)
e7e6de8 
Bumps [coverlet.msbuild](https://github.com/coverlet-coverage/coverlet) from 2.9.0 to 3.0.2.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](https://github.com/coverlet-coverage/coverlet/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@AArnott AArnott mentioned this issue May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add .NET Framework 3.5 support AArnott/Validation
2 participants
@AArnott @oghenez