Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Requires.ValidElements #44

Merged
merged 6 commits into from
Sep 27, 2020
Merged

Adds Requires.ValidElements #44

merged 6 commits into from
Sep 27, 2020

Conversation

scottdorman
Copy link
Contributor

Closes #41, adds Requires.ValidElements method and associated unit tests.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2020

Codecov Report

Merging #44 into master will increase coverage by 0.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   88.21%   88.88%   +0.67%     
==========================================
  Files           9        9              
  Lines         263      279      +16     
==========================================
+ Hits          232      248      +16     
  Misses         31       31              
Impacted Files Coverage Δ
src/Validation/Requires.cs 91.07% <100.00%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2378284...aa62127. Read the comment docs.

Copy link
Owner

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for contributing. A few comments.

src/Validation/Requires.cs Outdated Show resolved Hide resolved
test/Validation.Tests/RequiresTests.cs Outdated Show resolved Hide resolved
test/Validation.Tests/RequiresTests.cs Show resolved Hide resolved
test/Validation.Tests/RequiresTests.cs Outdated Show resolved Hide resolved
Removed using directive grouping blank lines and set an .editorconfig value to control it.
Added additional tests to validate null value parameter, a predicate that throws an exception, and that the message formatting is correct. Also changed the Assert.Throws to use an overload that verifies the exception parameter name.
.editorconfig Show resolved Hide resolved
src/Validation/Requires.cs Outdated Show resolved Hide resolved
src/Validation/Requires.cs Outdated Show resolved Hide resolved
src/Validation/Requires.cs Outdated Show resolved Hide resolved
src/Validation/Requires.cs Outdated Show resolved Hide resolved
Copy link
Owner

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@AArnott AArnott merged commit a6a5350 into AArnott:master Sep 27, 2020
AArnott added a commit that referenced this pull request May 2, 2023
Add machine-wide .NET install support off Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a ValidElements method to Requires
3 participants