-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Requires.ValidElements #44
Conversation
…eline build treats this as an error while it was just a warning locally.
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 88.21% 88.88% +0.67%
==========================================
Files 9 9
Lines 263 279 +16
==========================================
+ Hits 232 248 +16
Misses 31 31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for contributing. A few comments.
Removed using directive grouping blank lines and set an .editorconfig value to control it. Added additional tests to validate null value parameter, a predicate that throws an exception, and that the message formatting is correct. Also changed the Assert.Throws to use an overload that verifies the exception parameter name.
…ake a StringCompare parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
Add machine-wide .NET install support off Windows
Closes #41, adds
Requires.ValidElements
method and associated unit tests.