Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces the call to NotNull with a direct test. Closes #45. #50

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

scottdorman
Copy link
Contributor

Based on #45 (comment)

BTW, perf in this area hasn't come up for years. I personally wouldn't bother authoring these micro-optimizations.

I opted to just change Requires and not worry about the other classes.

For consistency, should I make the same change to vs-validation?

@codecov-commenter
Copy link

Codecov Report

Merging #50 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   90.90%   90.94%   +0.03%     
==========================================
  Files           9        9              
  Lines         275      276       +1     
==========================================
+ Hits          250      251       +1     
  Misses         25       25              
Impacted Files Coverage Δ
src/Validation/Requires.cs 96.33% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb6a8e9...926aaf3. Read the comment docs.

@scottdorman
Copy link
Contributor Author

Closes #45.

@AArnott AArnott merged commit ccb3156 into AArnott:master Sep 29, 2020
@AArnott
Copy link
Owner

AArnott commented Sep 29, 2020

consistency, should I make the same change to vs-validation?

Yes please

AArnott added a commit that referenced this pull request May 2, 2023
Stop passing $(System.AccessToken) as an arg in AzP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants