Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Submission. #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Project Submission. #3

wants to merge 1 commit into from

Conversation

ABDULALI3468
Copy link
Owner

@ABDULALI3468 ABDULALI3468 commented Oct 20, 2022

Hello rails back-end

This exercise is about creating a "Hello World" application to display a random message. The back-end is built with Rails and the front-end with React.

The PR for the front-end is Hello react front-end

This PR includes the following requirements:

General requirements

  • Make sure that there are no linter errors. Note for rails api projects without any styling files, delete the stylint configuration in the linter.yml file (line 23 -36) to avoid errors
  • Make sure that you used correct Gitflow.
  • Make sure that you documented your work in a professional way.

Ruby requirements

Project requirements

  • Create a new Rails API app called 'hello-rails-back-end'.
  • Initialize your project with Git.
  • Make sure that your project has a Postgres database set up.
  • Create a table for storing your messages and create 5 different greetings.
  • Create an API endpoint that selects a random greeting from your table (you will need a controller with an action an rails route).

Copy link

@Davidosky007 Davidosky007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ABDULALI3468 👋,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that doesn't follow proper Gitflow pattern You will need to create a pull request to compare your feature branch with the development branch and submit the link to that pull request via your Dashboard and also your Pull request lacks the necessary configuration ( that is the the linter checks excluding stylint file according to the project requirement)

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants