Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign splitpanebar #176

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Redesign splitpanebar #176

merged 7 commits into from
Oct 20, 2023

Conversation

alan-wu
Copy link
Member

@alan-wu alan-wu commented Oct 16, 2023

This pull request includes the following changes:

  • Entries state are now kept in store.
  • Simplify state being kept in the components.
  • Splitpanebar is now part of the with contentvuer component, making the logic easier to follow.
  • Remove unused component data.

Tehsurfer
Tehsurfer approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@Tehsurfer Tehsurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@alan-wu alan-wu merged commit df250a0 into ABI-Software:main Oct 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tehsurfer Tehsurfer Tehsurfer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alan-wu @Tehsurfer