Added a dataset header component to link to datasets #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-wu
reviewed
Apr 26, 2020
src/components/FloatingFlow.vue
Outdated
| @@ -168,16 +168,34 @@ export default { | |||
| mainTabName: "Flatmap", | |||
| zIndex: 1, | |||
| showDialogIcons: false, | |||
| dockedArray: [{title: "Flatmap", id:1}], | |||
| dockedArray: [{title: "Flatmap", id:1}, {title: "Heatmap", id:2}, {title: "Plot", id:3}], | |||
There was a problem hiding this comment.
I do not think we should have all three dialog docked right at the beginning. It will destroy the flow of the current use case. This can be added in the fetchContent method in the MapPopover module instead.
alan-wu
requested changes
Apr 27, 2020
src/components/FloatingFlow.vue
Outdated
| entries: [ | ||
| { | ||
| resource: "Human", availableSpecies : {"Human":{taxo: "NCBITaxon:9606", | ||
| iconClass:"icon-mapicon_human"}, "Rat":{taxo: "NCBITaxon:10114", iconClass:"icon-mapicon_rat"} }, | ||
| type: "Flatmap", zIndex:1, mode: "main", | ||
| id: 1 | ||
| } | ||
| id: 1, |
src/components/FloatingDialog.vue
Outdated
| <el-main class="dialog-main" :style="mainStyle"> | ||
| <DatasetHeader v-if="entry.datasetTitle" class="dataset-header" :title="entry.datasetTitle" :url="entry.datasetUrl"></DatasetHeader> |
There was a problem hiding this comment.
Have to take the height of the header into account. There is now overflow in the dalog. Create another div for the vuers with appropriate size. height: calc(100%-25px)?
- Switch to using an entry object as prop for DatasetHeader - Positions pop up cards based off click location - Switch to copying full entry object in 'FloatingFlow'
alan-wu
reviewed
May 18, 2020
src/components/FloatingFlow.vue
Outdated
| newEntry.id = ++this.currentCount; | ||
| newEntry.zIndex = ++this.zIndex; | ||
| this.entries.push(newEntry); | ||
| this.onFlowChange('createNewEntry'); | ||
| window.newEntry = newEntry |
alan-wu
reviewed
May 18, 2020
src/components/MapPopover.vue
Outdated
| @@ -102,6 +102,7 @@ export default { | |||
| ]; | |||
| break; | |||
| case "ICN": | |||
| console.log('in ICN') | |||
alan-wu
pushed a commit
that referenced
this pull request
Jul 22, 2022
Fix Search for dataset on upstream downstream not working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.