Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGL bug on Mac, shows up in schnakenberg example #19

Closed
sebjameswml opened this issue Apr 21, 2020 · 7 comments
Closed

OpenGL bug on Mac, shows up in schnakenberg example #19

sebjameswml opened this issue Apr 21, 2020 · 7 comments

Comments

@sebjameswml
Copy link
Collaborator

Looks like there's a null vertex that shows up when the schnakenberg example runs on a Mac.

I suspect a bug in the setting of vertices or normals in HexGridVisual.

Perhaps @stuartwilson would like to buy that Macbook for me to debug it ;)

@sebjameswml
Copy link
Collaborator Author

I think this bug is visible on Linux, too, though with a slightly different "look" - a black hex in the middle of one of the maps.

@jmartinbrooke
Copy link
Collaborator

jmartinbrooke commented May 29, 2020 via email

@sebjameswml
Copy link
Collaborator Author

sebjameswml commented Sep 14, 2020

I think this occurs when there is a bad value for a hex. On Linux, this shows as a black hex. As it happens, on the new Macbook Air, when the GL is linked to Cocoa, the horrible output that Stuart was seeing has gone. Even the black hexes don't show. The new build process in features/cmake_update improves the linking, and the build process for morphologica in general.

However, I need to look at the hexgrid visual code, to see what it does if one of the data variables is nan and make sure it falls back gracefully as far as creating the model vertices.

@sebjameswml
Copy link
Collaborator Author

2e03538 fixes the black hexes which were showing up.

@stuartwilson
Copy link
Collaborator

stuartwilson commented Sep 15, 2020 via email

@sebjameswml
Copy link
Collaborator Author

After some further changes to CMakeLists, this seems to have gone away for Stuart's Mac! See 6411246 for careful binding and unbinding code, which may have been the fix. Also fbc8a92 for incorporating OpenMP correctly - the GL rendering worked for Stuart when programs were compiled single-threaded. Maybe the rendering worked 'by accident'?

@sebjameswml
Copy link
Collaborator Author

Closing, as I believe this has gone now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants