Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add requestPinWidget method #192

Merged
merged 15 commits into from
Jan 15, 2024
Merged

Conversation

tenhobi
Copy link
Contributor

@tenhobi tenhobi commented Dec 11, 2023

Fixes #191

lib/home_widget.dart Outdated Show resolved Hide resolved
lib/home_widget.dart Outdated Show resolved Hide resolved
@tenhobi tenhobi changed the title pinWidget method requestPinWidget method Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (daea9c1) 100.00% compared to head (7f72480) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #192   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           69        73    +4     
=========================================
+ Hits            69        73    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petrnymsa
Copy link

LGTM! Tested in our application. Can you look at it @ABausG ? Thanks 🙏

@tenhobi
Copy link
Contributor Author

tenhobi commented Dec 13, 2023

Not really sure what the last iOS integration issue is, it seems unrelated to the PR.
image

Copy link
Owner

@ABausG ABausG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just some minor doumentation nibs.

Integration Failure is indeed not your fault. The Workflow did test the iOS part on flutter beta and it seems ViewConfiguration will change to named arguments.

I remember you talking about potentially adding a dart callback to the intent. While this possibly might be useful I don't think it is necessary to support this from the beginning and thus should not stop this from being added.

Could you also target the dev branch for this?

README.md Outdated Show resolved Hide resolved
lib/home_widget.dart Outdated Show resolved Hide resolved
test/home_widget_test.dart Outdated Show resolved Hide resolved
@tenhobi
Copy link
Contributor Author

tenhobi commented Dec 13, 2023

Awesome, will do tomorrow 💪

tenhobi and others added 2 commits December 15, 2023 08:17
Co-authored-by: Anton Borries <anton.borries@gmail.com>
@tenhobi tenhobi changed the base branch from main to dev December 15, 2023 07:21
@tenhobi tenhobi requested a review from ABausG December 15, 2023 07:22
@tenhobi
Copy link
Contributor Author

tenhobi commented Dec 15, 2023

Hi @ABausG, I just finished all the suggestions :)

@ABausG ABausG changed the base branch from dev to main January 7, 2024 15:42
@ABausG ABausG changed the title requestPinWidget method feat: Add requestPinWidget method Jan 7, 2024
@tenhobi
Copy link
Contributor Author

tenhobi commented Jan 9, 2024

So, can this be merged? 😊🙏

@ABausG ABausG merged commit 301703f into ABausG:main Jan 15, 2024
5 checks passed
@tenhobi tenhobi deleted the feat/pin-widget branch January 15, 2024 19:36
@tenhobi tenhobi restored the feat/pin-widget branch January 16, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinning widget
3 participants