-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add requestPinWidget method #192
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 69 73 +4
=========================================
+ Hits 69 73 +4 ☔ View full report in Codecov by Sentry. |
LGTM! Tested in our application. Can you look at it @ABausG ? Thanks 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Just some minor doumentation nibs.
Integration Failure is indeed not your fault. The Workflow did test the iOS part on flutter beta and it seems ViewConfiguration
will change to named arguments.
I remember you talking about potentially adding a dart callback to the intent. While this possibly might be useful I don't think it is necessary to support this from the beginning and thus should not stop this from being added.
Could you also target the dev
branch for this?
Awesome, will do tomorrow 💪 |
Co-authored-by: Anton Borries <anton.borries@gmail.com>
Hi @ABausG, I just finished all the suggestions :) |
So, can this be merged? 😊🙏 |
Fixes #191