Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HomeWidgetBackgroundWorker on iOS not setting Setup as completed #229

Merged
merged 1 commit into from Mar 5, 2024

Conversation

armandsLa
Copy link
Contributor

On iOS, the HomeWidgetBackgroundWorker doesn't function because the isSetupCompleted flag is always false. This happens because isSetupCompleted is set to true only when the backgroundInitialized callback runs after the first event is added to the queue, which happens rarely. To fix it, simply move isSetupCompleted outside the while loop.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e7d9831) to head (4c07a4c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #229   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           73        73           
=========================================
  Hits            73        73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ABausG ABausG changed the title Fix isSetupCompleted always false fix: HomeWidgetBackgroundWorker on iOS not setting Setup as completed Mar 5, 2024
Copy link
Owner

@ABausG ABausG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!! Was on my plate to check for this!

@ABausG ABausG merged commit 8b42df9 into ABausG:main Mar 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants