New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a way to to obtain information about the pinned widgets #233
Conversation
ABausG Can you take a look? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a had a quick first glance. All in all looks already really good and will be super helpful!
Am I correct in assuming that getting the size of an installed widget is not possible on Android as the way I understand the API and your implementation of accessing the Info is that using the widgetIds of the Installed/Pinned Widgets it gets the general configuration of the widget so a min/max size would be possible but not the actual size the user is using? I guess that Information is not really relevant to users of home_widget as they are defining that. Do you have any idea/experience if it would be possible to get that information anyway? Ideally in this call?
My original idea differed slightly, but you're grasping it well. Here's what I know:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 73 103 +30
=========================================
+ Hits 73 103 +30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
I just refactored some variables in HomeWidgetInfo to include OS prefixes for all variables to make everything a bit clearer and indicate why certain things might be null.
Excited to fit this in to the next release!
Would address
#129
#223
#37