Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CD Fixes #37

Merged
merged 2 commits into from
Feb 6, 2024
Merged

CD Fixes #37

merged 2 commits into from
Feb 6, 2024

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented Feb 6, 2024

In this PR:
* cd.yml: Only run deployments if PR changed config/spack.yaml

  • cd.yml: Fixed logic for getting the branch name of the last PR merged

Modified jq logic for finding the lasted merged PR. I had initially said that it should --limit 1 and I assumed (incorrectly) that the only PR it would return would be the most recently merged. It actually returned the highest PR number that had been merged!

@CodeGat CodeGat self-assigned this Feb 6, 2024
Copy link
Contributor

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the logic of the gh command

.github/workflows/cd.yml Show resolved Hide resolved
Copy link
Contributor

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@CodeGat CodeGat merged commit a05a060 into main Feb 6, 2024
@CodeGat CodeGat deleted the cd-fix branch February 6, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants