Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease deploy job runs on valid skipped jobs #41

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented Feb 7, 2024

In this PR:

  • deploy-version job checks out HEAD ref instead of the weird merge branch by default,
  • prerelease deploy happens on skipped jobs now

@CodeGat CodeGat self-assigned this Feb 7, 2024
aidanheerdegen
aidanheerdegen previously approved these changes Feb 7, 2024
Copy link
Contributor

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@CodeGat CodeGat merged commit e9364ca into main Feb 7, 2024
@CodeGat CodeGat deleted the prerelease-dependencies-fix branch February 7, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants