Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Validity Check and Full Commit History for Deployment Number #42

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented Feb 7, 2024

ci.yml: Now always checks if things in versions.json are valid, and fetch all history for commits on branch

@CodeGat CodeGat self-assigned this Feb 7, 2024
jo-basevi
jo-basevi previously approved these changes Feb 7, 2024
Copy link
Contributor

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aidanheerdegen
aidanheerdegen previously approved these changes Feb 7, 2024
Copy link
Contributor

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm asking questions about stuff that I've already approved. Soz. I'll assume it is ok though.

.github/workflows/ci.yml Show resolved Hide resolved
@CodeGat CodeGat dismissed stale reviews from aidanheerdegen and jo-basevi via 5c1ab5e February 7, 2024 03:22
Copy link
Contributor

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeGat CodeGat merged commit 8755808 into main Feb 7, 2024
@CodeGat CodeGat deleted the deploy-number-fix branch February 7, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants