Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow backported bugfixes to picked up by CI/CD #51

Merged
merged 7 commits into from
Mar 15, 2024

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented Mar 6, 2024

In this PR:

  • Added pull_request trigger for backport/*.* branches in all workflows. See the linked issue for an explanation of the new branching scheme.
  • Removed the restriction of pre-VERSION branch naming. We now get VERSION from the spack.yamls access-om2 spec.
  • ci.yml:
    • Restructured job dependencies
    • prerelease-deploy-version job now yqs spack.yaml to get the versions
  • cd.yml:
    • Simplified getting the tag name by just using the spack.yamls access-om2 spec version.
    • Removed the Prerelease cleanup, now in a new closed-pr.yml.
  • Added a closed-pr.yml workflow for Prerelease cleanup after PR.
  • Added a CONTRIBUTING.md and referenced it in the README.md.

Closes #50

aidanheerdegen
aidanheerdegen previously approved these changes Mar 7, 2024
Copy link
Contributor

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the excellent docs.

.github/workflows/cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@CodeGat CodeGat marked this pull request as ready for review March 15, 2024 03:06
Copy link
Contributor

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

.github/workflows/cd.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/pr-closed.yml Show resolved Hide resolved
.github/workflows/comment.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Bugfixes to existing versions of ACCESS-OM2
2 participants