-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow backported bugfixes to picked up by CI/CD #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanheerdegen
previously approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the excellent docs.
…pack.yaml, and restructured job dependencies
…fier job to get the spack-{packages,config} from the correct dependency
CodeGat
force-pushed
the
50-backported-bugfixes
branch
from
March 15, 2024 03:06
ad03ce6
to
6318f68
Compare
aidanheerdegen
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
pull_request
trigger forbackport/*.*
branches in all workflows. See the linked issue for an explanation of the new branching scheme.pre-VERSION
branch naming. We now get VERSION from thespack.yaml
saccess-om2
spec.ci.yml
:prerelease-deploy-version
job nowyq
sspack.yaml
to get the versionscd.yml
:spack.yaml
saccess-om2
spec version.closed-pr.yml
.closed-pr.yml
workflow for Prerelease cleanup after PR.CONTRIBUTING.md
and referenced it in theREADME.md
.Closes #50