Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in inset axes #74

Closed
wants to merge 1 commit into from
Closed

Conversation

anekimken
Copy link
Contributor

My code had a bug where the lines on the x axis of the estimation plot got drawn on every set of axes in the entire fig. Not a problem if all you have in the figure is the estimation plot, but still a problem if you have other.

@josesho josesho changed the base branch from master to v0.2.6 October 3, 2019 02:22
@josesho
Copy link
Member

josesho commented Oct 3, 2019

I spotted the same bug as well; and earlier pushed the same fix as you!

So I'm gonna close this PR, but thanks for the attention to detail.

FYI, I'm going to do a little writeup about this in the docs, and also fix #72 before I push 0.2.6 to master, as well as release to PyPi.

PS I should also add a note somewhere about which branches to PR to—ideally it should be on the dev branch (which is currently 0.2.6, and which I need to mark as such...)

@josesho josesho closed this Oct 3, 2019
@anekimken
Copy link
Contributor Author

Sounds good. This is actually the first time I’ve contributed to a package like this, so the dev branch might be more obvious for someone a bit more savvy.

@josesho
Copy link
Member

josesho commented Oct 3, 2019

I'm learning myself as well! This isn't on the scale of matplotlib or seaborn (and it shouldn't get there... God forbid!) but with more contributors like yourself we'll need a bit more scaffolding....

@josesho josesho mentioned this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants