Honor reflines_kwargs when float_contrast=False #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refline when float_contrast=False should honor reflines_kwargs
DizietAsahi
changed the title
fixed a bug when using the `slopegraph_kwargs`. Also added documentation for the `slopegraph_kwargs`
|
I've also included a fix for Issue #88 |
|
Hi @DizietAsahi, thanks for this!! I just got back into the office. Let me fix this over Christmas break. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #87
When using
float_contrast=False, the zero reference line does not honor the attributes passed inreflines_kwargs.I believe it would make sense that it does.