Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmoteCategory.Refuse not performing linked action, such as a custom tell #1212

Closed
ghost opened this issue Jan 1, 2019 · 3 comments
Closed
Assignees

Comments

@ghost
Copy link

ghost commented Jan 1, 2019

Bug Report or Feature Request (mark with an x)

- [X] bug report -> please search issues before submitting
- [ ] feature request

Repro steps.

As, one example, create a new character and try to hand the "Letter from Home" to the Society Greeter. She should respond with "This is yours. Keep it if you like, ..." tell. In current master, the NPC merely states "[NPC name] doesn't know what to do with this item."
Another, Samuel should have a custom response when handed the Restoring the Training Academies note from the room next to him.

Desired functionality.

Flavor text dialog should appear when items are handed to NPCs that are coded for EmoteCategory.Refuse

@ghost ghost changed the title Refuse emote not performing linked action Refuse emote not performing linked action, such as a custom tell Jan 1, 2019
@ghost ghost changed the title Refuse emote not performing linked action, such as a custom tell EmoteCategory.Refuse not performing linked action, such as a custom tell Jan 1, 2019
@ghost
Copy link
Author

ghost commented Jan 2, 2019

public bool HandleNPCReceiveItem() in WorldObject.cs does not account for EmoteCategory.Refuse

@gmriggs
Copy link
Collaborator

gmriggs commented Jan 4, 2019

A PR for this issue has been posted @ #1231

@ghost
Copy link
Author

ghost commented Jan 5, 2019

Confirmed fixed

@ghost ghost closed this as completed Jan 5, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant