Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Salvaging Bugs #1226

Closed
1 task done
someeodtech opened this issue Jan 3, 2019 · 1 comment
Closed
1 task done

Multiple Salvaging Bugs #1226

someeodtech opened this issue Jan 3, 2019 · 1 comment
Assignees

Comments

@someeodtech
Copy link

someeodtech commented Jan 3, 2019

  • [ X] bug report -> please search issues before submitting
  • feature request

### Repro steps.
<!-- Please list the steps to reproduce a bug here -->
- Salvage can achieve Workmanship values above 10, up to 38 has been observed
- Salvage can be increased by salvaging itself, as long as the value is over 0
- Salvage values can exceed 100, up to 283 has been observed
- Salvage Bags fail to change Icon to a full bag of salvage once reaching 100 e.g. such as the icon & type created by /ci 29581
- Salvage can be increased by salvaging against a bag of salvage with a value of 0 - as spawned by Admin commands; ex. /ci 20986
- Bags of Salvage such as Green Garnet display that they do not have any use, when code in RecipeManager shows otherwise

### The log given by the failure.
<!-- Normally this include a stack trace and some other information about the failure. -->
N/A

### Desired functionality.
<!--
What would like to see implemented?
What is the use case?
-->

### Mention any other details that might be useful.
<!-- Please include any information that can help clarify the request here -->
This behavior has been examined with multiple Material Types to Include:
Brass ; Steel ; Iron ; Green Garnet ; Black Opal ; Fire Opal ; Sunstone ; White Sapphire ; Imperial Topaz ; Bronze ; Silver ; Gold ; Ivory ; Reedshark Leather ; Granite ; Mahogany ; Teak ; Ebony ; Aquamarine ; Black Garnet ; Red Garnet ; Diamond ; Pyreal ; Lapis Lauzil ; Moonstone
@gmriggs gmriggs self-assigned this Jan 4, 2019
@gmriggs
Copy link
Collaborator

gmriggs commented Jan 16, 2019

All of the code issues for this are now fixed in #1257

For the salvage descriptions that say 'this salvage has no apparent use', the weenie descriptions need to be updated for those. Using the salvage should still perform the correct imbue

@gmriggs gmriggs closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants