Check inventory space before selling

[cyberkiller6]

Bug Report or Feature Request (mark with an x)

- [X] bug report -> please search issues before submitting
- [ ] feature request

Repro steps.

Create a character
Use command /currency to get 100mmds
Go to a NPC, sell those 100mmds.
Instead of receiving the only pyreal you have pack space for, the NPC should not allow you to sell and display an error of some sort that say's you don't have enough pack space to sell all 100 mmds.

The log given by the failure.

Desired functionality.

Instead of receiving the only pyreal you have pack space for, the NPC should not allow you to sell and display an error of some sort that say's you don't have enough pack space to sell all 100 mmds.

Mention any other details that might be useful.

[ghost]

I would say the probably a player's encumbrance should be checked, also, to ensure that it doesn't go out of bounds. Additional tasks that these checks should probably be performed with are crafting and emotes that have NPCs giving items to players.

[Mag-nus]

When you sell items, do they only go into your main pack or can they spill over into side packs as well?

[ghost]

In buying items or gaining pyreals from selling, the latter option is the case, if there isn't any space available in the main pack.

[fartwhif]

are you sure? i remember retail merchants not using the landscape packs and instead giving an error whenever the main pack is full and landscape packs have room when buying or selling, there is a character configuration option to always use your "currently open pack" so maybe you have that enabled? IMHO it doesn't have to match retail and could probably be less rigid than retail, which might even be easier to implement than perfectly cloning the retail server behavior.

[Mag-nus]

Should be resolved with #1452