War Magic Against Non Player Killers

[cyberkiller6]

Bug Report or Feature Request (mark with an x)

- [X] bug report -> please search issues before submitting
- [ ] feature request

Repro steps.

Hit another non player kill character with war magic.

The log given by the failure.

Desired functionality.

You should get a message saying you hit the person, but no damage was done because they are a non player killer.

Mention any other details that might be useful.

[cyberkiller6]

Message is absent.

No damage was dealt.

[gmriggs]

Testing this out, and I noticed a couple of things

The first time I tested this, I was indeed not getting any 'PK status invalid!' messages (similar when trying to cast negative creature/life/item spells on a player with a different pk status). I also noticed during this time, the spells were not exploding on impact... they would sort of disappear into the target, and then 5 seconds later, they would explode finally.

So I restarted for debugging, and this time I noticed that the war projectiles were indeed giving the feedback message this time (yellow transient error at the top, instead of chat box text... not sure if this matches retail), and this time the projectiles were also exploding correctly:

https://i.imgur.com/loJv0LX.jpg

I think this might be related to a bug that was reported a couple weeks ago, where if you /create crystalfragment, and then launch Arc spells at it from a distance, they would not detect as hitting the target beyond a certain distance

So I think the messages are working when the server detects the collision as occurring, I think this bug is related to the server not detecting the spell projectile collisions in some instances

Will be looking into this more

[gmriggs]

Hmm now i also cannot get the 'long Arc shot / no collision' bug to occur with fragments...

I did indeed see a bug similar to this the first time I tested the war projectiles between NPKs, but it seems like an inconsistent repro so far

[gmriggs]

These messages have been improved in #1363