Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items show +0% Mana Conversion #1500

Closed
cyberkiller6 opened this issue Mar 7, 2019 · 2 comments
Closed

Items show +0% Mana Conversion #1500

cyberkiller6 opened this issue Mar 7, 2019 · 2 comments

Comments

@cyberkiller6
Copy link

Bug Report or Feature Request (mark with an x)

- [X] bug report -> please search issues before submitting
- [ ] feature request

Repro steps.

https://imgur.com/a/g40X3wA

The log given by the failure.

Desired functionality.

Item should just not have a mana conversion bonus at all instead of displaying +0%

Mention any other details that might be useful.

Commit #1497 ACEWorldDatabase v0.9.22

@gmriggs gmriggs assigned ghost Mar 8, 2019
@gmriggs
Copy link
Collaborator

gmriggs commented Jul 25, 2019

This was a bug in the loot generator, and should be fixed

@gmriggs
Copy link
Collaborator

gmriggs commented Dec 14, 2019

Just to clarify, this was addressed in #2491

We actually found from retail pcaps, that this was an issue in retail too. Most of the items in retail did have 0 ManaConversionMod in the data, and it was sent during appraisal.

The data for these items is actually very inconsistent. In the base 16PY weenies, many of them have 0 ManaConversionMod, and many have it omitted.

So this is (unfortunately) working as per retail spec by default. A new server option has been added, /modifybool show_mana_conv_bonus_0 false, which will normalize the appraisal display for these items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants