Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cottage Storage Not working Correctly anymore. #1582

Closed
Warloxx01 opened this issue Mar 28, 2019 · 1 comment · Fixed by #1584
Closed

Cottage Storage Not working Correctly anymore. #1582

Warloxx01 opened this issue Mar 28, 2019 · 1 comment · Fixed by #1584
Assignees

Comments

@Warloxx01
Copy link

Warloxx01 commented Mar 28, 2019

Bug Report or Feature Request (mark with an x)

- [X ] bug report -> please search issues before submitting
- [ ] feature request

Repro steps.

Purchase a Cottage (Only Building I tried it in) go down and open the chest (Works) Double click the chest (won't Close) Close the Storage window (Closes) Chest remains open. Double Click the chest again, Nothing Happens at all. Appears to have started after the last patch (Not the DB update one, the one JUST before that one.) After working with this abit more it Looks like it maybe on a timer? Chest Closes by itself after a minuet or so. You can get the chest to close if you double click a house hook to.

The log given by the failure.

No Error Log Given.

Desired functionality.

Mention any other details that might be useful.

@ghost
Copy link

ghost commented Mar 28, 2019

The Close functionality was moved to Chest.CheckUseRequirements() from ActOnUse, in PR#1570. House Storage class has its own CheckUseRequirements() override which does not have this same Close() call. Storage() uses Chest.ActOnUse for its actions, which now doesn't include the if(IsOpen) check and associated Close() action if true, anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants