Implement latest route blinding spec updates #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
relay-blinded-payment-update
branch
3 times, most recently
from
b96c01b
to
5341b92
Compare
This was referenced Sep 9, 2022
t-bast
force-pushed
the
relay-blinded-payment-update
branch
from
5341b92
to
de20da9
Compare
Codecov Report
@@ Coverage Diff @@
## master #2408 +/- ##
==========================================
- Coverage 84.79% 84.76% -0.03%
==========================================
Files 199 199
Lines 15614 15643 +29
Branches 656 645 -11
==========================================
+ Hits 13240 13260 +20
- Misses 2374 2383 +9
|
And translate downstream errors when we're inside a blinded route, with a random delay when we're the introduction point.
Add more restrictions to the tlvs that can be used inside blinded payloads.
And reject blinded payments when the feature is disabled.
t-bast
force-pushed
the
relay-blinded-payment-update
branch
from
de20da9
to
c38f259
Compare
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/PaymentOnion.scala
Outdated
Show resolved
Hide resolved
thomash-acinq
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is best reviewed commit-by-commit: each commit contains a detailed description of what it achieves. This is a pre-requisite for #2395 and #2401, since it introduces a new
total_amount_msattlv which lets us get rid of thepayment_datafield.The first and third commits deserve more tests, but they cannot be added now since we're lacking the utilities to send to a blinded route. We will add those tests in a future PR, once all the components for blinded payments are available.
This implements the changes to lightning/bolts#765 after commit lightning/bolts@485c2b1 (included).