New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trampoline to blinded #2811
Trampoline to blinded #2811
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2811 +/- ##
==========================================
+ Coverage 85.86% 85.97% +0.10%
==========================================
Files 216 217 +1
Lines 18228 18248 +20
Branches 772 800 +28
==========================================
+ Hits 15652 15688 +36
+ Misses 2576 2560 -16
|
Does anyone know how to see these 3 lines ? |
The codecov website doesn't seem to show these, I guess they're trying to incentivize us to install their GitHub app but it's probably not worth it! |
087d96b
to
ee277d6
Compare
3d7f4bf
to
e94b8b8
Compare
Allow trampoline to pay a list of blinded paths instead of a node id. Only the last trampoline hop can target blinded paths, trampoline nodes are still reached with their node id, not with blinded paths.
e94b8b8
to
d8e19a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The architecture looks good to me, most feedback is nit.
eclair-core/src/main/scala/fr/acinq/eclair/payment/send/PaymentInitiator.scala
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/Relayer.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/NodeRelay.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/NodeRelay.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/NodeRelay.scala
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/NodeRelay.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/NodeRelay.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few nits in #2814 and this should be ready to go!
eclair-core/src/main/scala/fr/acinq/eclair/payment/send/CompactBlindedPathsResolver.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/NodeRelay.scala
Outdated
Show resolved
Hide resolved
Merged #2814 |
Allow trampoline to pay a list of blinded paths instead of a node id. Only the last trampoline hop can target blinded paths, trampoline nodes are still reached with their node id, not with blinded paths.