Add a "smooth" fee provider #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will return the moving average of fee estimates provided by its internal fee provider, within a user defined window that can be set with eclair.smooth-feerate-window. The default value is 1 which doe not change the current behaviour.
This should smooth our fee rate when there is a sudden change in onchain fees and prevent channels with c-lightning node from getting closed because they disagree with our fee rate.
pm47
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will return the moving average of fee estimates provided by its internal fee provider, within a user defined window that can be set with eclair.smooth-feerate-window. The default value is 1 which doe not change the current behaviour.
This should help prevent channels from getting closed when fees rise quickly and we send an
update feemessage that our peer disagrees with.