-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OutgoingPaymentsDb interface #117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We split payments into two parts: a top-level payment description and a list of partial payments (corresponding to the actual HTLCs that are sent).
This test suite should run against the SQL implementation as well to verify its correctness.
9d07630
to
010833a
Compare
dpad85
reviewed
Nov 26, 2020
The result is more future-proof and will make it possible to handle many different types of payments cleanly (swaps, pay-to-open, keysend, etc).
I've made many changes to the |
dpad85
approved these changes
Nov 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We split payments into two parts: a top-level payment description and a list of partial payments (corresponding to the actual HTLCs that are sent). This allows storing them in different tables to avoid duplicating data. It also makes it easier in the future to implement different payment types (swaps, keysend, etc).
Notes:
PaymentsDb
file: the rest is implementation details