Fix electrum client doubling 'Disconnected' event #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
reviewed
Jan 20, 2021
src/commonMain/kotlin/fr/acinq/eclair/blockchain/electrum/ElectrumClient.kt
Outdated
Show resolved
Hide resolved
romainbsl
force-pushed
the
fix/electrum-client
branch
from
9908ab6
to
a97d160
Compare
t-bast
approved these changes
Jan 20, 2021
sstone
approved these changes
Jan 20, 2021
romainbsl
pushed a commit
that referenced
this pull request
Jan 21, 2021
This reverts commit 8876962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, when calling
disconnect()we send aDisconnectedevent, that a some point cancel the coroutine job in charge of the TCP connection, that also send aDisconnectedevent.So, if between those both events we try to reconnect and thus change the state (e.i.
WaitingForVersion), the electrum client will go back toClosedright away.