Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize HTLCs only once #421

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Serialize HTLCs only once #421

merged 1 commit into from
Mar 23, 2023

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Feb 28, 2023

HTLCs are duplicated in local and remote commit(s), and across commitments when splices are ongoing. We now serialize them only once, which reduces the size of the encrypted backup that needs to be stored.

pm47
pm47 previously approved these changes Mar 23, 2023
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, roundtrip is tested in StateSerializationNonRegTestsCommon

HTLCs are duplicated in local and remote commit(s), and across commitments
when splices are ongoing. We now serialize them only once, which reduces
the size of the encrypted backup that needs to be stored.
@t-bast
Copy link
Member Author

t-bast commented Mar 23, 2023

Rebased.

@t-bast t-bast merged commit 4c5ba6f into master Mar 23, 2023
@t-bast t-bast deleted the serialize-htlcs-only-once branch March 23, 2023 17:37
@remyers remyers mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants