Add support for liquidity ads #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A liquidity lease rate is provided to the peer at startup using default values stored in the NodeParamsManager. Aggregated queries have been updated. Note that inbound liquidity payments use the `lockedAt` timestamp to define if the payment is complete or not. Also added a new `WalletPaymentId` for inbound liquidity payments, with internal code 6. Tests are missing. Cloud wrappers for inbound liquidity payments are not yet implemented.
A new screen has been added to request liquidity from the peer using liquidity-ads. The user can pick the an amount, and get an estimation of the cost (mining + service fee) of the liquidity. Then accept the offer, or cancel the request by leaving the screen. The liquidity is done with a splice. A button to that screen has been added in the home screen and in the liquidity policy screen. The channels view screen also shows the current inbound liquidity, using a linear progress bar.
Also let the user copy the CSV in the Android app.
pm47
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for liquidity ads, that is, a way to request inbound liquidity from your peer (ACINQ) using a new feature from the Lightning protocol.
See:
Main changes:
4269317 adds the necessary plumbing in the shared module, especially the new database objects
f5c511d adds the new UI for the Android application.
Note that the UI for the iOS application will be done in another PR.