Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lightning-kmp #51

Merged
merged 4 commits into from
May 16, 2024
Merged

Update lightning-kmp #51

merged 4 commits into from
May 16, 2024

Conversation

pm47
Copy link
Member

@pm47 pm47 commented May 15, 2024

We ignore BOLT12-related changes.

@pm47 pm47 requested a review from dpad85 May 15, 2024 09:45
dpad85
dpad85 approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@dpad85 dpad85 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we could add a toString in lightning-kmp for payment part failure objects (similar toFinalFailure) for a better error message.

@pm47 pm47 marked this pull request as ready for review May 15, 2024 17:08
@pm47 pm47 marked this pull request as draft May 15, 2024 17:08
@pm47 pm47 marked this pull request as ready for review May 16, 2024 16:06
@pm47 pm47 merged commit a97e577 into master May 16, 2024
@pm47 pm47 deleted the lightning-kmp-7 branch May 16, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpad85 dpad85 dpad85 approved these changes

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pm47 @dpad85 @vincenzopalazzo