Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Kotlin 1.9 #5

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Upgrade to Kotlin 1.9 #5

wants to merge 7 commits into from

Conversation

dpad85
Copy link
Member

@dpad85 dpad85 commented Jan 22, 2024

This pull request updates the project to Kotlin 1.9.

Changes

Gradle

  • Gradle is upgraded to 7.5
  • AGP to 7.4.2

We could upgrade to gradle/AGP 8.x and target API 34 on android, to match what is being done on Phoenix, but it's not mandatory.

Libraries

  • Ktor is upgraded to 2.3.7
  • secp256k1 to 0.13.0

Gradle config and iOS targets

The iOS source sets configuration has also been updated to match the new KMP syntax : we support iosX64 and iosArm64 out of the box.

TODO

@sstone, @robbiehanson :

  • iosSimulatorArm64 is not listed yet as it requires fixes in the tor_in_thread module first.
  • The native (tor, openssl ...) libraries have not been updated yet, but need to be.

Gradle is upgraded to 7.5, AGP to 7.4.2.

Ktor is upgraded to 2.3.7, and secp to a SNAPSHOT version.

The iOS source sets configuration has also been updated
to match the new KMP syntax : we support iOSX64 and
iOSArm64 out of the box.

However, iOSSimulatorArm64 is not listed as it requires
fixes in the `tor_in_thread` module first.

The native libraries have not been updated yet - but should
be afterward, in a separate commit.
@dpad85 dpad85 changed the title Upgrade to kotlin 1.9 Upgrade to Kotlin 1.9 Jan 22, 2024
This tag supports kotlin 1.9.
@dpad85
Copy link
Member Author

dpad85 commented Jan 25, 2024

@sstone I let you look at the iosSimulatorArm64 support.

Regarding the upgrade of the native libs (tor, openssl, libevent, xz), this can be done in a future PR, as you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants