Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JavaScript dependencies and documentation #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update JavaScript dependencies and documentation #3

wants to merge 4 commits into from

Conversation

thisisaaronland
Copy link

  • Update jQuery.js to v3.7.1
  • Update Slick.js to v1.8.1
  • Update documentation to note requirement on sass tool
  • Update documentation to note optional use of gojekyll tool

@sighmon
Copy link

sighmon commented Nov 27, 2023 •
edited
Loading

@sam-s-maher Testing steps for me:

  1. Update rvm with: rvm get head
  2. Install Ruby 3.2.2 with: PKG_CONFIG_PATH="/opt/homebrew/opt/openssl@1.1/lib/pkgconfig" rvm install 3.2.2 --with-open-ssl-dir=/opt/homebrew/opt/openssl@1.1
  3. Install dependencies: gem install bundler jekyll
  4. Run: jekyll serve
  5. Install gojekyll: go install github.com/osteele/gojekyll@latest
  6. Run (I don't have my go bin path loaded on this machine): ~/go/bin/gojekyll serve

sighmon
sighmon approved these changes Nov 27, 2023
View reviewed changes
Copy link

@sighmon sighmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for updating the dependencies. Works for me locally with one suggestion.

readme.md Outdated Show resolved Hide resolved
sam-s-maher
sam-s-maher approved these changes Nov 30, 2023
View reviewed changes
Copy link

@sam-s-maher sam-s-maher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the steps @sighmon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighmon sighmon sighmon approved these changes

@sam-s-maher sam-s-maher sam-s-maher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thisisaaronland @sighmon @sam-s-maher