Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#30 Add extended codec information #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sighmon
Copy link
Contributor

@sighmon sighmon commented Jun 27, 2024

Resolves #30

It would help collections to add extended codec information to the metadata output.

  • Add codec_long_name and codec_tag_string to the video and audio codec output

Testing

  1. Update your local storage volume location in docker-compose-dev.yml
  2. Add locations to your dev.env
  3. Add a video file to the watch folder
  4. Re-build the transcoder: make build
  5. Note the csv in the output folder now has extended video_codec and audio_codec information
  6. Note tests pass: docker exec -it transcoder make test
  7. Note linting and tests pass docker exec -it transcoder make lint
  8. Note we now have GitHub Actions as well: https://github.com/ACMILabs/transcoder/actions

Example output:

{
  "title": "ACMI_COLLECTIONS_SEARCH_PROMO_draft1_GL_23052024",
  "width": 1920,
  "height": 1080,
  "checksum": "754b5d21c6327291388b54e874c4c0a2",
  "filetype": "m",
  "mime_type": "video/mp4",
  "vernon_id": "",
  "audio_codec": "AAC (Advanced Audio Coding) (mp4a)",
  "video_codec": "H.264 / AVC / MPEG-4 AVC / MPEG-4 part 10 (avc1)",
  "duration_hms": "00:00:35:01",
  "duration_secs": 35.029333,
  "audio_bit_rate": 317219,
  "audio_channels": 2,
  "video_bit_rate": 19878604,
  "file_size_bytes": 88465999,
  "overall_bit_rate": 20203867,
  "video_frame_rate": 25.0,
  "audio_sample_rate": 48000,
  "creation_datetime": "2024-05-23 08:02:35+00:00",
  "audio_max_bit_rate": null,
  "video_max_bit_rate": null
}

Copy link

@rubyquaildesign rubyquaildesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lot of linting changes

While you're updating this, reckon you can change the default branch from master to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extended codec information
2 participants