Fix UnitTest to work in CakePHP 3.2.x #34
Conversation
|
The failing check is that the COVERALLS test is run on a PHP 5.4, but when updating this to run on CakePHP 3.2.x we need PHP 5.5+. |
|
Need to update the coveralls build to use PHP 7 instead. You can refer to https://github.com/cakephp/cakephp/blob/master/.travis.yml |
| @@ -1,7 +1,6 @@ | |||
| language: php | |||
|
|
|||
| php: | |||
| - 5.4 | |||
There was a problem hiding this comment.
We need to test on 5.4 since Cake 3.0 supports it :)
|
Jeez don't just copy paste the travis config from core repo. Just refer to it and make necessary changes to get the coveralls builds running. |
|
Whoops.. sorry!! |
|
And then... The tests are passing and .travis.yml has been updated to reflect the newest testing as done in the core cakephp project. Why the COVERALLS=1 test is failing, I've got no clue why. |
Remove wrongly commited code
|
@AD7six Do you see any problems with this PR? If so, please let me know :) |
| allow_failures: | ||
| - env: COVERALLS=1 DEFAULT=0 DB=mysql db_dsn='mysql://travis@0.0.0.0/cakephp_test' | ||
|
|
||
|
|
Fix UnitTest to work in CakePHP 3.2.x
No description provided.